Repository navigation
Add dividers to More menu actions - #90097
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 049fb16bbb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| REPORT_SECONDARY_ACTIONS.REOPEN, | ||
| REPORT_SECONDARY_ACTIONS.REJECT, | ||
| REPORT_SECONDARY_ACTIONS.APPROVE, | ||
| REPORT_SECONDARY_ACTIONS.UNAPPROVE, | ||
| REPORT_SECONDARY_ACTIONS.CANCEL_PAYMENT, |
There was a problem hiding this comment.
Include receivedPayment in report menu section map
getSecondaryReportActions() can emit REPORT_SECONDARY_ACTIONS.RECEIVED_PAYMENT (see src/libs/ReportSecondaryActionUtils.ts), but this action is missing from REPORT_MORE_MENU_SECTIONS. Because sortAndSectionPopoverMenuItems() sends unrecognized actions to the last section, Received payment is moved below utility/destructive items and gets an extra separator, which regresses the intended grouping/order whenever that action is available.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@aswin-s The review comment seems reasonable. What do you think?
There was a problem hiding this comment.
RECEIVED_PAYMENT got added later which we added in #91928
f154aab to
8dbb566
Compare
Include RECEIVED_PAYMENT in the first section of REPORT_MORE_MENU_SECTIONS between APPROVE and UNAPPROVE so it groups correctly with payment workflow actions instead of falling to the unrecognized section.
RECEIVED_PAYMENT no longer exists in CONST.REPORT.SECONDARY_ACTIONS on main, so remove it from the section map and its test.
8dbb566 to
a1160b8
Compare
|
🚧 @flaviadefaria has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp90097-android-hybrid-001.mp4Android: mWeb Chrome90097-mweb-chrome-001.mp4iOS: HybridApp90097-ios-hybrid-001.mp4iOS: mWeb Safari90097-mweb-safari-001.mp4MacOS: Chrome / Safari90097-web-chrome-001.mp4 |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
Hey design team, could you check out this PR to add menu dividers please. AdHoc build incoming |
This comment has been minimized.
This comment has been minimized.
|
It's looking really good to me! |
|
Agree, feels nice! |
Julesssss
left a comment
There was a problem hiding this comment.
Pre-approving, lets see what @dubielzyk-expensify thinks
|
Looks good to me as well 👍 |
Julesssss
left a comment
There was a problem hiding this comment.
Design approved, merging
|
@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.84-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR and the help site articles under No help site changes are required. This PR adds visual dividers (section separators) to the "More" popover menu — it's a purely visual/styling enhancement. No menu items were added, removed, or renamed, and no user-facing workflows changed. The relevant help articles I checked:
Since the documentation describes actions and workflows rather than menu styling, no updates are needed. @aswin-s, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #91912 was identified to be related to this PR. |
|
Deploy Blocker #91928 was identified to be related to this PR. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.86-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR against the help site articles under No help site changes are required. This PR adds visual dividers (section separators) between grouped items in the "More" popover menu. It does not add, remove, or rename any menu actions, nor does it change any user-facing workflows or behaviors. The relevant help articles — @aswin-s, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.88-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR and the existing help site articles under No help site changes are required. This PR adds visual dividers (thin separator lines) between logical sections of the "More" popover menu on reports and transactions. It is a purely cosmetic/UX enhancement:
The relevant help site articles (Expense and Report Actions, Understanding Report Statuses and Actions, Duplicate a Report) document what actions are available and how to access them — they do not describe the visual layout or grouping of menu items, so no updates are needed. @aswin-s, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀
|
Explanation of Change
Adds visual dividers/section separators to the "More" popover menu actions in money request and report headers. Introduces a
PopoverMenuSections.tsutility to group menu items into logical sections with dividers, and updatesPopoverMenuto render section dividers between grouped items.Fixed Issues
$ #87964
PROPOSAL: #87964 (comment)
Tests
Report with multiple expenses (Money Report):
Report with a single expense:
Held expense on a report:
Individual expense (Transaction header):
Primary action filtering:
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android-web.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.Web.mp4
MacOS: Chrome / Safari
MacOS.mp4